magento/magento2#37983: Place order with disabled Payment method working

[KrasnoshchokBohdan]

• prevent order placement with unavailable payment method

Description (*)

I will leave here examples of mutations that I used.

createCustomer

mutation {
  createCustomer(
    input: {
      firstname: "Test"
      lastname: "User"
      email: "[email protected]"
      password: "Password123"
    }
  ) {
    customer {
      id
      email
    }
  }
}

generateCustomerToken

mutation {
  generateCustomerToken(
    email: "[email protected]"
    password: "Password123"
  ) {
    token
  }
}

createEmptyCart (don't forget about Authentification)

mutation {
  createEmptyCart
}

addSimpleProductsToCart

mutation {
  addSimpleProductsToCart(
    input: {
      cart_id: "SOMEID" # Replace with the ID from Step 3
      cart_items: [
        {
          data: {
            quantity: 1
            sku: "test2" # Replace with an actual product SKU from your store
          }
        }
      ]
    }
  ) {
    cart {
      items {
        product {
          name
          sku
        }
        quantity
      }
    }
  }
}

setShippingAddressesOnCart

mutation {
  setShippingAddressesOnCart(
    input: {
      cart_id: "SOMEID" # Replace with the ID from Step 3
      shipping_addresses: [
        {
          address: {
            firstname: "Test"
            lastname: "User"
            company: "Company Name"
            street: ["123 Main Street"]
            city: "New York"
            region: "NY"
            postcode: "10001"
            country_code: "US"
            telephone: "1234567890"
            save_in_address_book: false
          }
        }
      ]
    }
  ) {
    cart {
      shipping_addresses {
        firstname
        lastname
        street
        city
        region {
          code
          label
        }
        postcode
        country {
          code
          label
        }
        telephone
      }
    }
  }
}

setBillingAddressOnCart

mutation {
  setBillingAddressOnCart(
    input: {
      cart_id: "SOMEID" # Replace with the ID from Step 3
      billing_address: {
        address: {
          firstname: "Test"
          lastname: "User"
          company: "Company Name"
          street: ["123 Main Street"]
          city: "New York"
          region: "NY"
          postcode: "10001"
          country_code: "US"
          telephone: "1234567890"
          save_in_address_book: false
        }
        same_as_shipping: false
      }
    }
  ) {
    cart {
      billing_address {
        firstname
        lastname
        street
        city
        region {
          code
          label
        }
        postcode
        country {
          code
          label
        }
        telephone
      }
    }
  }
}

setShippingMethodsOnCart

mutation {
  setShippingMethodsOnCart(
    input: {
      cart_id: "SOMEID" # Replace with the ID from Step 3
      shipping_methods: [
        {
          carrier_code: "flatrate"
          method_code: "flatrate"
        }
      ]
    }
  ) {
    cart {
      shipping_addresses {
        selected_shipping_method {
          carrier_code
          method_code
          carrier_title
          method_title
        }
      }
    }
  }
}

setPaymentMethodOnCart + placeOrder

mutation setPaymentMethodAndPlaceOrder(
  $cartId: String!
  $paymentMethod: PaymentMethodInput!
) {
  setPaymentMethodOnCart(
    input: { cart_id: $cartId, payment_method: $paymentMethod }
  ) {
    cart {
      selected_payment_method {
        code
        title
      }
    }
  }

  placeOrder(input: { cart_id: $cartId }) {
    order {
      order_number
    }
  }
}

VARIABLES

{
    "cartId": "SOMEID",
    "paymentMethod": {
        "code": "checkmo"
    }
}

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#37983

Manual testing scenarios (*)

1. Disable the checkmo payment method in admin
2. Create a quote using GraphQL
3. Set addresses and shipping method in GraphQL
4. Use a combined mutation with setPaymentMethodOnCart and placeOrder
5. Observe that despite the payment method error, an order is still created

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @KrasnoshchokBohdan,

Thanks for the contribution!

Please refer to the below review comment and also please add some automated test in accordance to the DOD.

Thanks

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run Integration Tests, Unit Tests, Functional Tests CE

[engcom-Hotel]

Hello @KrasnoshchokBohdan,

It seems you have made the changes according to the review comments, hence we are picking this PR for review.

Thank You 😃

[engcom-Hotel]

@magento run Unit Tests, WebAPI Tests

[engcom-Hotel]

@KrasnoshchokBohdan Some tests are still failing due to the PR changes. Moving back to Changes Requested bucket.

Thanks

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[KrasnoshchokBohdan]

@magento run WebAPI Tests

[KrasnoshchokBohdan]

@magento run all tests

[engcom-Charlie]

Hi @KrasnoshchokBohdan,

Thank you for your contribution!

Since you have marked this PR as draft moving this to On Hold bucket. Please feel free to move it to Review or let us know once done with changes.

Thank you!

[engcom-Bravo]

Hi @KrasnoshchokBohdan,

Thank you for your contribution! The Magento core engineering team is working on the issue which you have addressed in this PR. Team will cherry pick the commits from your PR and may do further implementation to cover few more scenarios as needed. We will reach out to you if we need more information. For now, you can pause work on this PR. Thank you once again!

[engcom-Bravo]

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-9605 by the internal team
Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-9605&type=commits

Based on the Jira ticket, the target version is 2.4.9-beta1.

Thanks