-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev rds ssl #392
Draft
MariuszJozwiak
wants to merge
19
commits into
rocky-develop
Choose a base branch
from
dev-rds-ssl
base: rocky-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dev rds ssl #392
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4640999
Add possibility to switch pkg manager with configuration option
Szpadel 3a2c89a
feat: MOPS-326 queue consumers optimization
9acebd3
Add missing dependency to new relic role
Szpadel 9ac5381
Deployment process finish without checking if Magento can pass the tr…
MariuszJozwiak d233c8c
Resolve issue with basic 503 error page
Szpadel 58b9a21
Make sure that awscli is installed before boto ans boto3
Szpadel a48d3fd
Restore cloudflare custom role
Szpadel 1d6f819
Update centos7 ami
Szpadel da12c1d
Place cloudflare exclusive traffic into correct location
Szpadel 89ab044
Expose pio quality target spread option as pio_quality_target_spread
Szpadel 1a56fea
QA/Testing Team request to skip varnish cache.
MariuszJozwiak f3cb2a2
Allow dynamic setting of new_relic license
Szpadel 1c88493
Allow access to Data Lifecycle Manager for full access policy
Szpadel 366a50e
Add missing help entry to mageopscli
Szpadel 0b5f9cb
Create symlink to new geoip configuration location (#382)
Szpadel 33783c0
Generate new configuration for geoupdate 6.x
Szpadel 060e4ea
Add permissions required for aws dlm
Szpadel d4cff8c
Fix typos in dlm roles profile names
Szpadel 17cb5b0
init
MariuszJozwiak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,17 @@ | ||
- name: Download CA RDS | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is downloaded so many times. Why? Cant we just download it once ? Or check if it does not exists? |
||
ansible.builtin.get_url: | ||
url: https://truststore.pki.rds.amazonaws.com/eu-central-1/eu-central-1-bundle.pem | ||
dest: /tmp/eu-central-1-bundle.pem | ||
mode: '0666' | ||
|
||
- name: Ensure project database exists | ||
mysql_db: | ||
login_host: "{{ mageops_mysql_host }}" | ||
login_user: "{{ mageops_mysql_root_user }}" | ||
login_password: "{{ mageops_mysql_root_pass }}" | ||
name: "{{ mageops_app_mysql_db }}" | ||
state: present | ||
ca_cert: /tmp/eu-central-1-bundle.pem | ||
|
||
- name: Ensure project db user for external connections exists | ||
mysql_user: | ||
|
@@ -15,6 +22,7 @@ | |
password: "{{ mageops_app_mysql_pass }}" | ||
host: "%" | ||
state: present | ||
ca_cert: /tmp/eu-central-1-bundle.pem | ||
priv: "{{ mageops_app_mysql_db }}.*:{{ mysql_configure_all_db_permissions }}" | ||
|
||
- name: Ensure project db user for localhost exists | ||
|
@@ -26,5 +34,6 @@ | |
password: "{{ mageops_app_mysql_pass }}" | ||
host: "localhost" | ||
state: present | ||
ca_cert: /tmp/eu-central-1-bundle.pem | ||
priv: "{{ mageops_app_mysql_db }}.*:{{ mysql_configure_all_db_permissions }}" | ||
when: mysql_user_localhost_access |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not store permament files in temp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make that confirurable and resonable