Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloudfront usage #467

Open
wants to merge 1 commit into
base: rocky-develop
Choose a base branch
from
Open

Fix cloudfront usage #467

wants to merge 1 commit into from

Conversation

MariuszJozwiak
Copy link
Contributor

There was missing rule that execute cloudfront every time even when it should be skipped.

@Szpadel
Copy link
Member

Szpadel commented Mar 18, 2025

Why disable cloudfront discovery?
This does not look like good approach to this issue, why not just disable setting up cloudfront to magento?
Like here: https://github.com/mageops/ansible-infrastructure/blob/rocky-master/group_vars/all.yml#L1153-L1175

@MariuszJozwiak MariuszJozwiak force-pushed the dev-fixcloudfront branch 2 times, most recently from 0aa3463 to 4d7b783 Compare March 20, 2025 07:27
@MariuszJozwiak MariuszJozwiak marked this pull request as draft March 20, 2025 08:03
@mageops mageops deleted a comment from Szpadel Mar 20, 2025
@MariuszJozwiak MariuszJozwiak marked this pull request as ready for review March 20, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Szpadel Szpadel Awaiting requested review from Szpadel

@monsad monsad Awaiting requested review from monsad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MariuszJozwiak @Szpadel