Skip to content

change node version in Dockerfile and package.json #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

monsad
Copy link

@monsad monsad commented Jul 14, 2025

No description provided.

@monsad monsad requested review from Copilot and Szpadel July 14, 2025 10:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Node runtime version used in the Docker image and bumps the TypeScript dependency version.

  • Bump TypeScript devDependency from ^3.8.3 to ^3.9.10
  • Change Docker base image from node:12-alpine to node:20-alpine

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Updated typescript version to ^3.9.10
build/Dockerfile Switched Docker base image from node:12-alpine to node:20-alpine
Comments suppressed due to low confidence (3)

package.json:11

  • The @types/node version is still pinned to Node 13 types; consider updating it to match Node 20 (e.g., ^20.x) so your type definitions align with the new runtime.
    "@types/node": "^13.13.1",

package.json:12

  • After bumping the TypeScript version, please update and commit the lockfile (e.g., package-lock.json or yarn.lock) so the dependency tree stays in sync and reproducible.
    "typescript": "^3.9.10"

build/Dockerfile:1

  • [nitpick] Consider updating any related project configurations—such as CI workflows, .nvmrc, or the engines field in package.json—to also use Node 20 so all environments remain consistent.
FROM node:20-alpine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant