API v2 #21
Open
API v2 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stigi
commented
Feb 14, 2025
stigi
added a commit
to magicbell/magicbell-js
that referenced
this pull request
Feb 14, 2025
The v1 user client supports token auth ([code](https://github.com/magicbell/magicbell-js/blob/794f5220f485415863e414bf500d8d982ff66663/packages/magicbell/src/user-client.ts/#L14)), but that was not available in react-headless ([code](https://github.com/magicbell/magicbell-js/blob/794f5220f485415863e414bf500d8d982ff66663/packages/react-headless/src/stores/clientSettings.ts/#L6-L15)). This PR allows to pass the `token` through the `MagicBellProvide` to the `UserClient` where it was already accepted. I've tested this in magicbell/mobile-inbox#21 where I used the preview package and can confirm that notifications load successfully when using a v2 JWT token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
This updates the app to follow the v2 API:
@magicbell/user-clientinstead ofmagicbell/user-clientTest Plan
Signed in with a JWT token and saw the device token registered in the dashboard.
CleanShot.2025-02-13.at.18.02.48.mp4
Type of Change