Skip to content

Migrate to official BouncyCastle.Cryptography #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2025
Merged

Migrate to official BouncyCastle.Cryptography #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d140a5
Migrate to BouncyCastle.Cryptography
skibitsky Sep 2, 2025
0bf912a
Fix culture in tests
skibitsky Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Solana.Unity.Extensions/Models/TokenWallet/TokenQuantity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using Solana.Unity.Extensions.Models.TokenMint;
using System;
using System.Globalization;
using System.Collections.Generic;
using System.Linq;
using System.Text;
Expand Down Expand Up @@ -74,9 +75,9 @@ internal TokenQuantity(TokenDef tokenDef,
public override string ToString()
{
if (Symbol == TokenName)
return $"{QuantityDecimal} {Symbol}";
return $"{QuantityDecimal.ToString(CultureInfo.InvariantCulture)} {Symbol}";
else
return $"{QuantityDecimal} {Symbol} ({TokenName})";
return $"{QuantityDecimal.ToString(CultureInfo.InvariantCulture)} {Symbol} ({TokenName})";
}

/// <summary>
Expand Down
5 changes: 3 additions & 2 deletions src/Solana.Unity.Extensions/Models/TokenWallet/TokenWalletBalance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using Solana.Unity.Extensions.Models.TokenMint;
using System;
using System.Globalization;
using System.Collections.Generic;
using System.Linq;
using System.Text;
Expand Down Expand Up @@ -50,9 +51,9 @@ internal TokenWalletBalance(TokenDef tokenDef,
public override string ToString()
{
if (Symbol == TokenName)
return $"{QuantityDecimal} {Symbol}";
return $"{QuantityDecimal.ToString(CultureInfo.InvariantCulture)} {Symbol}";
else
return $"{QuantityDecimal} {Symbol} ({TokenName})";
return $"{QuantityDecimal.ToString(CultureInfo.InvariantCulture)} {Symbol} ({TokenName})";
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Solana.Unity.KeyStore/Solana.Unity.KeyStore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="BouncyCastle.Cryptography" Version="2.6.1" />
<PackageReference Include="Chaos.NaCl.Standard" Version="1.0.*" />
<PackageReference Include="Portable.BouncyCastle" Version="1.9.*" />
<PackageReference Include="IsExternalInit" Version="1.0.*" PrivateAssets="all" />
<PackageReference Include="IndexRange" Version="1.0.*" />
<PackageReference Include="Newtonsoft.Json" Version="13.*" PrivateAssets="all" />
Expand Down
2 changes: 1 addition & 1 deletion src/Solana.Unity.Wallet/Bip39/Mnemonic.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ private static byte[] GenerateSeed(byte[] password, byte[] salt)
{
Pkcs5S2ParametersGenerator gen = new(new Sha512Digest());
gen.Init(password, salt, 2048);
return ((KeyParameter)gen.GenerateDerivedParameters(512)).GetKey();
return ((KeyParameter)gen.GenerateDerivedMacParameters(512)).GetKey();
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Solana.Unity.Wallet/Solana.Unity.Wallet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleToAttribute">
<_Parameter1>Solana.Unity.Wallet.Test</_Parameter1>
</AssemblyAttribute>
<PackageReference Include="BouncyCastle.Cryptography" Version="2.6.1" />
<PackageReference Include="Chaos.NaCl.Standard" Version="1.0.*" />
<PackageReference Include="Portable.BouncyCastle" Version="1.9.*" />
<PackageReference Include="System.Memory" Version="4.5.*"/>
<PackageReference Include="IndexRange" Version="1.0.*"/>
<PackageReference Include="System.Security.Cryptography.Algorithms" Version="4.3.*" />
Expand Down
Loading