feat: on failed txn checks, return more diagnostics info

[bmuddha]

Summary by CodeRabbit

• Bug Fixes

  • Enhanced error reporting for account access violations now includes specific account identifiers for improved diagnostics.
  • Improved handling of failed transactions by logging detailed execution information and preserving transaction records.

• Chores

  • Updated core dependency versions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The PR modifies account access validation error handling to return detailed error information including the problematic account's public key. Failed validations are now converted to synthetic executed transactions with diagnostic logs rather than propagating errors directly. Supporting test coverage for rent collection and fee payer validation scenarios is removed.

Changes

Cohort / File(s)	Summary
Dependency Update Cargo.toml	Updated solana-account patch revision from a892d2 to 731fa50
Validation Error Handling src/access_permissions.rs	Modified validate_accounts_access() return type from TransactionResult<()> to Result<(), (TransactionError, Pubkey)>. Added Pubkey import. Enhanced error reporting to include the account public key of failed validations. Destructured account iteration to expose public keys.
Transaction Validation Processing src/transaction_processor.rs	Changed failed account access validation to create synthetic ExecutedTransaction with diagnostic logs instead of propagating error. Includes debug message identifying the offender account.
Test Removals src/account_loader.rs, src/rollback_accounts.rs, src/transaction_processor.rs	Removed tests: test_collect_rent_from_account_rent_paying, test_collect_rent_from_account_rent_enabled, test_new_fee_payer_only, and test_validate_transaction_fee_payer_rent_paying

Sequence Diagram

sequenceDiagram
    participant TP as TransactionProcessor
    participant AP as AccessPermissions
    participant Ledger
    
    TP->>AP: validate_accounts_access(message)
    
    alt Validation Passes
        AP-->>TP: Ok(())
        TP->>Ledger: Process transaction normally
    else Validation Fails
        AP-->>TP: Err((TransactionError, Pubkey))
        rect rgb(255, 200, 200)
            Note over TP: Create synthetic ExecutedTransaction<br/>with error status & diagnostic log
        end
        TP->>Ledger: Push as ProcessedTransaction::Executed
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Return type signature change in validate_accounts_access() affects callers and error propagation semantics; verify all call sites handle the new tuple format correctly
• Error handling flow transformation in transaction_processor.rs converts validation errors into synthetic executed transactions; confirm diagnostic logs are appropriate and ledger state remains consistent
• Test removals across three files suggest behavioral changes; verify removed tests are no longer applicable and no coverage gaps remain for critical paths

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: improving error diagnostics by returning more detailed information on failed transaction checks, which is evident across all modified files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bmuddha/feat/improved-txn-diagnostics

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11bbaf2 and 78f5f29.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (5)

• Cargo.toml (1 hunks)
• src/access_permissions.rs (3 hunks)
• src/account_loader.rs (0 hunks)
• src/rollback_accounts.rs (0 hunks)
• src/transaction_processor.rs (1 hunks)

💤 Files with no reviewable changes (2)

• src/account_loader.rs
• src/rollback_accounts.rs

🧰 Additional context used

🧬 Code graph analysis (1)

src/transaction_processor.rs (2)

src/access_permissions.rs (1)

• validate_accounts_access (25-44)

src/transaction_processing_result.rs (3)

• execution_details (84-89)
• status (63-68)
• executed_units (91-95)

🔇 Additional comments (3)

src/transaction_processor.rs (1)

472-494: Synthetic transaction approach for enhanced diagnostics.

The implementation creates a synthetic ExecutedTransaction when account access validation fails, rather than propagating the error directly. This allows the transaction to be persisted to the ledger with diagnostic information (including the offending account's public key in the log message), which improves debuggability for users.

The approach is unconventional but aligns well with the PR objective to "return more diagnostics info on failed txn checks."

src/access_permissions.rs (1)

1-44: LGTM! Enhanced error reporting with offending account details.

The function signature change to return Result<(), (TransactionError, Pubkey)> enables much better diagnostics by exposing which specific account violated the validation rules. The implementation is clean, well-documented, and maintains the original validation logic while adding the offending account's public key to error returns.

This change integrates well with the synthetic transaction handling in src/transaction_processor.rs to provide detailed diagnostic information to users.

Cargo.toml (1)

130-130: Dependency revision 731fa50 verified as valid and accessible.

The git revision for solana-account exists in the upstream repository. The commit (731fa5037bf89929da76759f2281c1cb4833a8b7) dated 2025-11-19 is a bug fix release addressing COW (copy-on-write) diff checks and flag equality validation. No breaking changes, security concerns, or compatibility issues are indicated.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[GabrielePicco]

LGTM!