feat: check risk strategies

[Dodecahedr0x]

Summary

Introduce a configurable risk checking strategy: aggressively check all delegation actions, or only those involving programs relevant to money laundering: token programs and the magic program. Closes #1435

Breaking Changes

• None, but a new optional config field

Summary by CodeRabbit

• New Features

  • Added configurable AML verification strategies for all signers or only relevant program activity.
  • Risk checks now use a dedicated risk server, with relevant-program checks enabled by default.
  • Migrated task scheduling to Hydra cranks, including task creation, cancellation, funding, and faucet delegation.
  • Added configurable faucet keypair support for scheduler operations.

• Documentation

  • Updated configuration guidance for risk-server settings, AML strategies, and scheduler faucet setup.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds configurable AML risk checking with AllSigners and RelevantPrograms. The risk client now uses a risk-server verdict. The task scheduler now creates and cancels faucet-funded Hydra cranks instead of storing tasks in SQLite. Validator startup delegates the configured faucet. Legacy crank execution support was removed.

Assessment against linked issues:

Objective	Addressed	Explanation
Add configurable risk checking to avoid checking all addresses for every action [#1435]	✅

Assessment against linked issues: Out-of-scope changes:

Code Change	Explanation
Hydra crank scheduler migration (magicblock-task-scheduler/src/service.rs:1-320, magicblock-task-scheduler/src/crank.rs:1-183)	Replaces SQLite task scheduling with Hydra crank creation and cancellation. This is not part of configurable AML risk checking.
Faucet delegation and scheduler startup changes (bins/magicblock-validator/src/crank_faucet.rs:12-139, bins/magicblock-validator/src/leader.rs:176-193,539-567)	Adds faucet delegation and scheduler initialization behavior unrelated to the linked AML objective.
Legacy crank execution removal (magicblock-magic-program-api/src/instruction.rs:306, programs/magicblock/src/magicblock_processor.rs:171-174)	Removes the ExecuteCrank instruction and processor entrypoint. This is outside the linked risk-checking objective.

Suggested reviewers: bmuddha, gabrielepicco, thlorenz

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dode/configurable-aml-checks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@magicblock-chainlink/src/chainlink/fetch_cloner/mod.rs`:
- Around line 1577-1582: The signer collection in lines 1584-1602 currently
includes signers from all delegation_actions regardless of the check_strategy
result, which defeats the risk-check optimization. After the
delegation_actions_require_risk_check guard, add conditional logic based on
risk_service.check_strategy(): when the strategy indicates RelevantPrograms,
filter the actions with instruction_involves_risk_relevant_program before
collecting signers; when the strategy indicates AllSigners, preserve the current
behavior of collecting from all actions. Also add a test case that validates the
filtering behavior by including a mixed batch with both relevant and unrelated
actions to ensure only relevant signers are sent to check_addresses.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 37aea70b-9b7d-4458-a5a8-acf7df61fc2d

📥 Commits

Reviewing files that changed from the base of the PR and between 65d1e07 and b7addc0.

📒 Files selected for processing (7)

• config.example.toml
• magicblock-aml/src/lib.rs
• magicblock-chainlink/src/chainlink/fetch_cloner/mod.rs
• magicblock-chainlink/src/chainlink/fetch_cloner/tests.rs
• magicblock-chainlink/tests/10_aml_undelegation.rs
• magicblock-config/src/config/chain.rs
• magicblock-config/src/config/mod.rs

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[Dodecahedr0x]

• feat: check risk strategies #1429 👈 (View in Graphite)
• refactor(engine): overhaul the validator codebase around MagicBlock Engine #1452 : 2 other dependent PRs (#1369 , #1407 )
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[GabrielePicco]

LGTM!

[bmuddha]

LGTM