Revert "feat: Cleaner gasless implementation" #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 84fd7b8.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
27 files reviewed, 4 comments
Edit PR Review Bot Settings | Greptile
Comment on lines
+245
to
+246
| let config = toml::from_str::<EphemeralConfig>(toml).unwrap(); | ||
| assert!(config.accounts.payer.try_init_lamports().is_err()); |
There was a problem hiding this comment.
style: Add assertion for specific error type instead of just checking is_err()
Comment on lines
205
to
+206
| assert_eq!(post.len(), 1); | ||
| assert_eq!(post[0], [LAMPORTS_PER_SOL - 2 * expected_fee, 9103680, 1, 1141440]); | ||
| assert_eq!(post[0], [LAMPORTS_PER_SOL - 2 * LAMPORTS_PER_SIGNATURE , 9103680, 1, 1141440]); |
There was a problem hiding this comment.
syntax: Extra space before the closing bracket in array access
Suggested change
| assert_eq!(post.len(), 1); | |
| assert_eq!(post[0], [LAMPORTS_PER_SOL - 2 * expected_fee, 9103680, 1, 1141440]); | |
| assert_eq!(post[0], [LAMPORTS_PER_SOL - 2 * LAMPORTS_PER_SIGNATURE , 9103680, 1, 1141440]); | |
| assert_eq!(post.len(), 1); | |
| assert_eq!(post[0], [LAMPORTS_PER_SOL - 2 * LAMPORTS_PER_SIGNATURE, 9103680, 1, 1141440]); |
Comment on lines
+132
to
+134
| /// The payer init balance in lamports. | ||
| /// Read it via [Self::try_init_lamports]. | ||
| pub init_lamports: Option<u64>, |
There was a problem hiding this comment.
logic: The public visibility of init_lamports combined with the comment directing to use try_init_lamports() creates a potential source of bugs. Consider making init_lamports private.
| } | ||
| Ok(match self.init_lamports { | ||
| Some(lamports) => Some(lamports), | ||
| None => self.init_sol.map(|sol| sol * LAMPORTS_PER_SOL), |
There was a problem hiding this comment.
logic: Integer overflow possible when multiplying sol by LAMPORTS_PER_SOL. Add checked_mul() to handle large values safely.
Suggested change
| None => self.init_sol.map(|sol| sol * LAMPORTS_PER_SOL), | |
| None => self.init_sol.and_then(|sol| sol.checked_mul(LAMPORTS_PER_SOL)), |
thlorenz
added a commit
that referenced
this pull request
Jul 2, 2025
* master: release: v0.1.7 (#409) Feat: simpler gasless implementation (#406) perf: run ensure accounts concurrently feat: account hydration on background task (#407) Revert "feat: Cleaner gasless implementation" (#405) feat: Cleaner gasless implementation (#360) fix: cleanup slots on non-fresh ledger (#404) release: v0.1.5 (#403) fix: properly init geyser plugin for rpc and use valid dummy Library (#402) release: v0.1.4 (#401) fix: remove grpc plugin altogether from geyser manager (#400) Patch tests from failing on subscription due to rate limits (#386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #360
Greptile Summary
This PR reverts a gasless transaction implementation (#360), restoring traditional fee handling across the codebase.
LAMPORTS_PER_SIGNATUREfrom 0 back to 5000 inmagicblock-bank/src/consts.rs, re-enabling standard transaction feesconfigs/ephem-*.tomlfiles, requiring SOL for transaction fees againmagicblock-config/src/errors.rsto prevent ambiguous account initialization (lamports vs SOL)Cargo.tomlmagicblock-bank/src/genesis_utils.rsto restore fee-based transaction processing