Feat/gasless #406
Merged
Feat/gasless #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
<!-- greptile_comment --> ## Greptile Summary Removed free airdrop functionality and payer configurations across the MagicBlock validator, transitioning towards a gasless transaction model. - Removed `payer_init_lamports` field and related configurations from `configs/ephem-devnet.toml` and `configs/ephem-testnet.toml`, eliminating automatic account funding - Simplified fee payer account cloning in `magicblock-account-cloner/src/remote_account_cloner_worker.rs` by using standard `do_clone_undelegated_account` method for non-charging validators - Removed `Payer` struct and related functionality from `magicblock-config/src/accounts.rs`, including configuration validation and environment variable handling - Modified account initialization logic in `magicblock-api/src/magic_validator.rs` to support gasless transactions while maintaining validator identity and faucet account funding <!-- /greptile_comment -->
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
27 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Comment on lines
259
to
262
| assert_eq!( | ||
| author_acc.lamports(), | ||
| LAMPORTS_PER_SOL - 2 * LAMPORTS_PER_SIGNATURE | ||
| LAMPORTS_PER_SOL - 2 * DEFAULT_LAMPORTS_PER_SIGNATURE | ||
| ); |
There was a problem hiding this comment.
style: Same account balance assertion being repeated - consider extracting this check into a helper function since it's used twice with identical logic
| let fee_payer = Keypair::new(); | ||
| let instruction = create_noop_instruction( | ||
| &elfs::noop::id(), | ||
| &[fee_payer.insecure_clone()], |
There was a problem hiding this comment.
logic: Use of insecure_clone() is dangerous for keypairs - prefer regular clone() unless there's a specific need for insecure cloning
thlorenz
added a commit
that referenced
this pull request
Jul 2, 2025
* master: release: v0.1.7 (#409) Feat: simpler gasless implementation (#406) perf: run ensure accounts concurrently feat: account hydration on background task (#407) Revert "feat: Cleaner gasless implementation" (#405) feat: Cleaner gasless implementation (#360) fix: cleanup slots on non-fresh ledger (#404) release: v0.1.5 (#403) fix: properly init geyser plugin for rpc and use valid dummy Library (#402) release: v0.1.4 (#401) fix: remove grpc plugin altogether from geyser manager (#400) Patch tests from failing on subscription due to rate limits (#386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #360
Greptile Summary
Major architectural changes to implement native gasless transaction support by removing automatic airdrops and modifying fee handling across the validator.
magicblock-bank/src/consts.rsto setDEFAULT_LAMPORTS_PER_SIGNATUREto 0 and integrate with patched solana-svm for zero-fee transactionsmagicblock-accounts/src/config.rsmagicblock-bank/src/genesis_utils.rsto support configurable transaction feesCargo.tomlto use custom magicblock-labs/magicblock-svm fork at commit e93eb57magicblock-bank/tests/transaction_execute.rs