use max/min price from product price object#260
Merged
Marvin-Magmodules merged 1 commit intomagmodules:masterfrom Jan 13, 2026
Merged
use max/min price from product price object#260Marvin-Magmodules merged 1 commit intomagmodules:masterfrom
Marvin-Magmodules merged 1 commit intomagmodules:masterfrom
Conversation
Member
|
Thanks @sanderjongsma! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also came across this bug: #201. While it can be considered a Magento bug, I think it’s better to use the price model to get the min/max price. This does not check for out-of-stock products and simply returns prices based on the bundle options.
The reason I think this is better is that you don’t want sales channels to show an incorrect price, even if a child item is out of stock and therefore the entire bundle is out of stock.
I added an extra check for dynamic pricing, since that’s the only case where the min/max price is relevant.