Enable SMTP relay if configured via environment variables. #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoshData Any feedback on this? |
JoshData
reviewed
Feb 16, 2025
| "smtp_sasl_security_options = noanonymous" \ | ||
| "smtp_sasl_password_maps = hash:/etc/postfix/sasl_passwd" \ | ||
| "smtp_use_tls = yes" \ | ||
| "smtp_tls_security_level = encrypt" \ |
There was a problem hiding this comment.
This changes the value that we set elsewhere.
There was a problem hiding this comment.
I have tested this and did not see any impact on the overall behaviour of my box other than the relaying.
Though happy to scope it down. Can you elaborate what specifically you see is conflicting?
There was a problem hiding this comment.
The purpose of relayhost is to send all mail via the relay, so the settings should match the relay. It doesn´t matter anymore how we set them elsewhere. However, if we don´t want to use the relay anymore, make sure the settings are restored to their original settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables SMTP relaying through an external SMTP server by setting corresponding environment variables prior to running the installer. This is useful to workaround SMTP sending restrictions and IP address reputability issues often faced on hosting platforms and cloud providers.