Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve grammar and style, including capitalization and phrasing #285

Merged
merged 5 commits into from
Feb 19, 2025
Merged

docs: improve grammar and style, including capitalization and phrasing #285

merged 5 commits into from
Feb 19, 2025

Conversation

newzealandpaul
Copy link
Contributor

The example crowsnet.conf does not specify what use_proxy is for and it is not immediately obvious.

The issue is discussed in #34

mryel00
mryel00 reviewed Jan 11, 2025
View reviewed changes
Copy link
Member

@mryel00 mryel00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
As we are touching the config now, it might be good to fix all the other things in the comments of this config as well, e.g. wild mix of uppercase and lowercase.

@mryel00 mryel00 changed the title Added comment to annotate what use_proxy option is for docs: add comment to annotate purpose of use_proxy option Jan 11, 2025
@mryel00 mryel00 changed the title docs: add comment to annotate purpose of use_proxy option docs: improve grammar and style, including capitalization and phrasing Feb 14, 2025
@mryel00 mryel00 changed the base branch from master to develop February 14, 2025 22:47
@mryel00 mryel00 merged commit 5b6c88d into mainsail-crew:develop Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteyou meteyou meteyou approved these changes

@mryel00 mryel00 mryel00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newzealandpaul @meteyou @mryel00