Initial support for exclamation in command line #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eraserhd
requested changes
Oct 12, 2016
| :else | ||
| (assoc :message [:white :red (str ":" command-line " is not a thing")])))) | ||
| [editor command-line-raw] | ||
| (let [force? (have-exclamation? command-line-raw) |
There was a problem hiding this comment.
Did you know that Clojure symbols can have ! in them?
I would just define w! and wq! and so forth as separate commands in avi.commands.
| @@ -29,7 +29,7 @@ | |||
| (editor :after ":q") => unfinished?) | |||
| (fact "`:q<Enter>` exits Avi" | |||
| (editor :after ":q<Enter>") => finished?) | |||
| (fact "`:q!<Enter>` does not exit Avi" | |||
| (future-fact "`:q!<Enter>` does not exit Avi" | |||
There was a problem hiding this comment.
In general, if you see a test like this, it's calling out that the behavior is intentional. In this case, though, we were trying to come up with a different model for saving, but never succeeded. So I would just change this to a
(fact "`:q!<Enter>` exits Avi"
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to write logic within individual commands and update tests.
Had to move one test to future-fact as the same I was not sure of the behaviour.