refactor: remove try/catch

maizzle · Feb 16, 2023 · 847d7f3 · 847d7f3
1 parent aaec86d
commit 847d7f3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 19 deletions.
diff --git a/src/index.js b/src/index.js
@@ -48,14 +48,10 @@ module.exports = () => {
 
       await importCwd(bin).build(env)
 
-      try {
-        updateNotifier({
-          pkg: importCwd('./node_modules/@maizzle/framework/package.json'),
-          shouldNotifyInNpmScript: true,
-        }).notify()
-      } catch (error) {
-        throw error
-      }
+      updateNotifier({
+        pkg: importCwd('./node_modules/@maizzle/framework/package.json'),
+        shouldNotifyInNpmScript: true,
+      }).notify()
     })
 
   program
@@ -66,17 +62,13 @@ module.exports = () => {
     .action((env, options) => {
       const bin = options.bin || './node_modules/@maizzle/framework/src'
 
-      try {
-        importCwd(bin).serve(env, {
-          build: {
-            console: {
-              clear: !options.noclear,
-            },
+      importCwd(bin).serve(env, {
+        build: {
+          console: {
+            clear: !options.noclear,
           },
-        })
-      } catch (error) {
-        throw error
-      }
+        },
+      })
     })
 
   program
@@ -86,6 +78,7 @@ module.exports = () => {
     .option('-v, --version', 'output current framework and CLI versions')
     .on('option:version', () => {
       const pkg = require('../package.json')
+
       try {
         const maizzle = importCwd('./node_modules/@maizzle/framework/package.json')
         console.log(`Framework v${maizzle.version}\nCLI v${pkg.version}`)

diff --git a/xo.config.js b/xo.config.js
@@ -3,7 +3,6 @@ module.exports = {
   rules: {
     semi: 0,
     camelcase: 0,
-    'no-useless-catch': 0,
     'arrow-body-style': 0,
     'unicorn/prefer-module': 0,
     'unicorn/string-content': 0,