change order of transformers, put function below the guard #1110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have faced with the error, when use keepOnlyAttributeSizes. The error was attrStr.split is not a function. After investigation has found that the error coms from transformers => removeInlineSizes.js => parseAttrs => _attr => parseAtr. The reason was that transformer removeUnusedCSS remove classes and leave class attribute as is. And than while parsing not the string was the argument but the boolean, wich caused the error.
So I change the order of transformers so after the removeInlineCSS will invoke removeAttributes wich will remove single class attribute.
Also while investigating has found that there is sense to move parsing below the guard in removeInlineSizes.js to prevent some unnecessary operations.