Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Conversation

@coreywright
Copy link

@coreywright coreywright commented Aug 22, 2017

Heed Python's subprocess module documentation warnings about deadlock
when using PIPE for a Popen object's stderr with Popen.wait() and
Popen.stderr.read() and use Popen.communicate() instead.

Fixes #126.

@coreywright
Copy link
Author

coreywright commented Aug 22, 2017

the pep8 violation ./tests/test_imports.py:13:1: E305 expected 2 blank lines after class or function definition, found 1 is a "pre-existing condition" (disclaimer: not covered under the terms of this PR's insurance policy), but resolved by #127.

Heed Python's subprocess module documentation warnings about deadlock
when using PIPE for a Popen object's stderr with Popen.wait() and
Popen.stderr.read() and use Popen.communicate() instead.

Fixes major#126.
@coreywright coreywright force-pushed the avoid_deadlock_with_subprocess branch from 3af09c4 to 67146a4 Compare August 22, 2017 18:33
@codecov-io
Copy link

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #128   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         392    391    -1     
  Branches       82     82           
=====================================
- Hits          392    391    -1
Impacted Files Coverage Δ
supernova/supernova.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a217ae...67146a4. Read the comment docs.

@coreywright
Copy link
Author

coreywright commented Aug 22, 2017

force pushed up a new commit to clarify where these warnings, as referenced in the commit message, exist (ie Python's subprocess module documentation).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants