Fixed _get_importances bug #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry its taken me so long to look into this - there are instances where 'imp' occurs at the end of a string instead, which this would break I think. Would it make more sense to replace the line to search for 'imp:' instead? |
shimwell
reviewed
Apr 28, 2023
|
|
||
| # check for importance keyword | ||
| if "imp" in self.file_lines[idx]: | ||
| if self.file_lines[idx].startswith('imp'): |
There was a problem hiding this comment.
How about checking the start and end of the line
Suggested change
| if self.file_lines[idx].startswith('imp'): | |
| if self.file_lines[idx].startswith('imp') or self.file_lines[idx].endswith('imp') : |
There was a problem hiding this comment.
having just had a similar issue i found we already had a pr to fix
endswith wont work,
changing the search to "imp:" makes the most sense
There was a problem hiding this comment.
Suggested change
| if self.file_lines[idx].startswith('imp'): | |
| if self.file_lines[idx].startswith('imp:'): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was attempting to convert an MCNP file, which had the word 'implicit' in one of the tally comment cards. This broke the _get_importances function in MCNPInputs so fixed with a startswith operation on the string.