Skip to content

Commit

Permalink
fix: typo and naming conventions
Browse files Browse the repository at this point in the history
  • Loading branch information
sriramveeraghanta committed Nov 19, 2024
1 parent a01a371 commit 1325064
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from django.conf import settings

# Module imports
from plane.license.models import Instance, EditionTypes
from plane.license.models import Instance, InstanceEdition
from plane.license.bgtasks.tracer import instance_traces


Expand Down Expand Up @@ -55,7 +55,7 @@ def handle(self, *args, **options):
latest_version=payload.get("version"),
last_checked_at=timezone.now(),
is_test=os.environ.get("IS_TEST", "0") == "1",
edition=EditionTypes.PLANE_CE.value,
edition=InstanceEdition.PLANE_COMMUNITY.value,
)

self.stdout.write(self.style.SUCCESS("Instance registered"))
Expand All @@ -69,7 +69,7 @@ def handle(self, *args, **options):
instance.current_version = payload.get("version")
instance.latest_version = payload.get("version")
instance.is_test = os.environ.get("IS_TEST", "0") == "1"
instance.edition = EditionTypes.PLANE_CE.value
instance.edition = InstanceEdition.PLANE_COMMUNITY.value
instance.save()

# Call the instance traces task
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,32 @@


class Migration(migrations.Migration):

dependencies = [
('license', '0004_changelog_deleted_at_instance_deleted_at_and_more'),
("license", "0004_changelog_deleted_at_instance_deleted_at_and_more"),
]

operations = [
migrations.RenameField(
model_name='instance',
old_name='product',
new_name='edition',
model_name="instance",
old_name="product",
new_name="edition",
),
migrations.RemoveField(
model_name='instance',
name='license_key',
model_name="instance",
name="license_key",
),
migrations.RemoveField(
model_name='instance',
name='user_count',
model_name="instance",
name="user_count",
),
migrations.AddField(
model_name='instance',
name='is_test',
model_name="instance",
name="is_test",
field=models.BooleanField(default=False),
),
migrations.AlterField(
model_name="instance",
name="edition",
field=models.CharField(default="PLANE_COMMUNITY", max_length=255),
),
]
2 changes: 1 addition & 1 deletion apiserver/plane/license/models/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
Instance,
InstanceAdmin,
InstanceConfiguration,
EditionTypes,
InstanceEdition,
)
6 changes: 3 additions & 3 deletions apiserver/plane/license/models/instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
ROLE_CHOICES = ((20, "Admin"),)


class EditionTypes(Enum):
PLANE_CE = "plane-ce"
class InstanceEdition(Enum):
PLANE_COMMUNITY = "PLANE_COMMUNITY"


class Instance(BaseModel):
Expand All @@ -23,7 +23,7 @@ class Instance(BaseModel):
current_version = models.CharField(max_length=255)
latest_version = models.CharField(max_length=255, null=True, blank=True)
edition = models.CharField(
max_length=255, default=EditionTypes.PLANE_CE.value
max_length=255, default=InstanceEdition.PLANE_COMMUNITY.value
)
domain = models.TextField(blank=True)
# Instance specifics
Expand Down

0 comments on commit 1325064

Please sign in to comment.