Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3230]fix: cycle labels overflow issue #6526

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

vamsikrishnamathala
Copy link
Collaborator

@vamsikrishnamathala vamsikrishnamathala commented Jan 31, 2025

Description

This update fixes the labels overflow issue in cycles progress.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

References

WEB-3230

Summary by CodeRabbit

  • Style
    • Improved label and title display in components by adding truncation and ellipsis classes
    • Enhanced text overflow handling to prevent layout disruptions
    • Ensured long label and title names are visually managed within their containers

Copy link
Contributor

coderabbitai bot commented Jan 31, 2025

Walkthrough

The pull request focuses on improving the visual presentation of labels in two React components: ActiveCycleStats and SingleProgressStats. The changes involve adding CSS classes to manage text overflow and truncation, ensuring that long label names are displayed cleanly without disrupting the layout. The modifications are purely visual and do not alter the underlying component logic or functionality.

Changes

File Change Summary
web/core/components/cycles/.../active-cycle/cycle-stats.tsx Added truncate class to label div and text-ellipsis truncate classes to label span for better text overflow handling
web/core/components/cycles/.../analytics-sidebar/progress-stats.tsx Modified label title container class from gap-2 to gap-2 truncate and label span class from text-xs to text-xs text-ellipsis truncate

Possibly related PRs

Suggested reviewers

  • rahulramesha
  • SatishGandham
  • anmolsinghbhatia

Poem

🐰 Labels long and labels wide,
Truncate with grace, let text reside!
No more overflow, no layout strife,
Ellipsis saves the day with style so rife!
Coding magic, rabbit's delight! 🎉


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ddad176 and f95a6e1.

📒 Files selected for processing (2)
  • web/core/components/cycles/active-cycle/cycle-stats.tsx (1 hunks)
  • web/core/components/cycles/analytics-sidebar/progress-stats.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: lint-web
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (2)
web/core/components/cycles/analytics-sidebar/progress-stats.tsx (1)

138-145: LGTM! Good handling of label text overflow.

The changes effectively handle long label names by:

  • Preventing container overflow
  • Maintaining the color indicator size
  • Adding ellipsis for truncated text
web/core/components/cycles/active-cycle/cycle-stats.tsx (1)

318-325: LGTM! Consistent handling of label text overflow.

The changes maintain consistency with the progress-stats.tsx file and effectively handle long label names using the same pattern:

  • Container overflow prevention
  • Fixed color indicator size
  • Text truncation with ellipsis

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sriramveeraghanta sriramveeraghanta merged commit 0deec92 into preview Jan 31, 2025
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-cycles_labels branch January 31, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants