Callback routes #17
Open
Callback routes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
regilero
commented
Feb 24, 2025
regilero
commented
- Introduce OIDCHelper, as trying to manipulate routes directly from the provider would make infinite dependencies loops with settings.
- get_urlpatterns is moved inside OIDCHelper
- Side note: when using get_urlpatterns to generates routes in tests this must be defined in the test settings and cannotbe overriden later in individual tests, as the route assignement is done early
- Fix the callback_uri_name/callback_path/callback names mess tobe able to handle routes with prefix. e2e tests done in lemonldap integration currently.
gbip
reviewed
Feb 24, 2025
Comment on lines
+160
to
+172
| if "oidc_paths_prefix" in op_definition: | ||
| # we cannot be sure that this part will be the full path at the end | ||
| # because the routes based on this path can be used in prefix | ||
| # but we can document that when prefix are used the callback_uri_name | ||
| # is a better way to define callback path. | ||
| # here this will only work when no route prefix is used. | ||
|
|
||
| # remove '/' prefix if any." | ||
| if op_definition["oidc_paths_prefix"][:1] == "/": | ||
| op_definition["oidc_paths_prefix"] = op_definition["oidc_paths_prefix"][ | ||
| 1: | ||
| ] | ||
|
|
There was a problem hiding this comment.
Je crois que la méthode str.strip() te permet de faire la même chose !
gbip
reviewed
Feb 24, 2025
| @@ -239,6 +271,9 @@ def get( | |||
| return default | |||
| return res | |||
|
|
|||
| def provider(self) -> Provider: | |||
There was a problem hiding this comment.
Ici peut être que c'est intéressant de décorer avec @property ?
gbip
reviewed
Feb 28, 2025
Comment on lines
+174
to
+176
| op_definition[ | ||
| "oidc_callback_path" | ||
| ] = f"{op_definition['oidc_paths_prefix']}-callback" |
There was a problem hiding this comment.
Ici je pense qu'il faudrait résoudre le nom de l'url avec la fonction reverse (ou reverse_lazy) de jdango.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.