Skip to content

Show Toaplan test switch as input instead of dip switch, remove default keybind #13916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jackrjli
Copy link
Contributor

@jackrjli jackrjli commented Jul 7, 2025

Fixes #13882

Copy link
Member

@angelosa angelosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only doubt: is Test Switch for the label the right expression for this?

@jackrjli
Copy link
Contributor Author

jackrjli commented Jul 7, 2025

My only doubt: is Test Switch for the label the right expression for this?

It's labeled as "TEST SW" in the manual for Truxton II (see row 15 in the table on page 2) as well as for Batsugun and Dogyuun, so keeping that name makes sense to me.

@happppp
Copy link
Member

happppp commented Jul 8, 2025

I removed the hidden F1 keybinding here: d1aeddf

It doesn't look like having it as a normal input instead of an on/off switch makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toaplan test switch keybinding cannot be changed
3 participants