-
Notifications
You must be signed in to change notification settings - Fork 21
Add initial testing for Emscripten CI #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
=======================================
Coverage 87.97% 87.97%
=======================================
Files 100 100
Lines 7649 7649
=======================================
Hits 6729 6729
Misses 920 920
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
You may have to rebase to fix the failing builds on OSX |
0fef1f4
to
24351bb
Compare
Hey @Alex-PLACET @JohanMabille This should get us started with the initial testing for the emscripten build in the CI. As mentioned in #549 (comment) , it's just 4 files that currently might bother us here and there. I shall go about addressing those in the subsequent PRs. But apart from those, we are doing good
|
Can we merge it ? |
Should be ready I think. |
Currently we have the following