Skip to content

Conversation

anutosh491
Copy link
Contributor

Currently we have the following

(xeus-lite-host) anutosh491@Anutoshs-MacBook-Air Release % node test_sparrow_lib.js
[doctest] doctest version is "2.4.12"
[doctest] run with "--help" for options
===============================================================================
/Users/anutosh491/work/sparrow/test/test_builder.cpp:64:
TEST SUITE: builder
TEST CASE:  timestamp-layout
  timestamp_milliseconds_array

/Users/anutosh491/work/sparrow/test/test_builder.cpp:64: ERROR: test case THREW exception: exception thrown in subcase - will translate later when the whole test case has been exited (cannot translate while there is an active exception)

===============================================================================
/Users/anutosh491/work/sparrow/test/test_builder.cpp:64:
TEST SUITE: builder
TEST CASE:  timestamp-layout

DEEPEST SUBCASE STACK REACHED (DIFFERENT FROM THE CURRENT ONE):
  timestamp_milliseconds_array

/Users/anutosh491/work/sparrow/test/test_builder.cpp:64: ERROR: test case THREW exception: discover_tz_dir failed to find zoneinfo


===============================================================================
[doctest] test cases:    722 |    721 passed | 1 failed | 0 skipped
[doctest] assertions: 351320 | 351320 passed | 0 failed |
[doctest] Status: FAILURE!

Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.97%. Comparing base (05bb857) to head (fb955aa).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   87.97%   87.97%           
=======================================
  Files         100      100           
  Lines        7649     7649           
=======================================
  Hits         6729     6729           
  Misses        920      920           
Flag Coverage Δ
unittests 87.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Alex-PLACET
Copy link
Collaborator

You may have to rebase to fix the failing builds on OSX

@anutosh491 anutosh491 mentioned this pull request Sep 8, 2025
@anutosh491 anutosh491 marked this pull request as ready for review September 8, 2025 07:20
@anutosh491 anutosh491 changed the title [wip] Add CI and testing for emscripten builds Add initial testing for Emscripten CI Sep 8, 2025
@anutosh491
Copy link
Contributor Author

Hey @Alex-PLACET @JohanMabille

This should get us started with the initial testing for the emscripten build in the CI.

As mentioned in #549 (comment) , it's just 4 files that currently might bother us here and there. I shall go about addressing those in the subsequent PRs.

But apart from those, we are doing good

[doctest] doctest version is "2.4.12"
[doctest] run with "--help" for options

[doctest] test cases:    709 |    709 passed | 0 failed | 0 skipped
[doctest] assertions: 351022 | 351022 passed | 0 failed |
[doctest] Status: SUCCESS!

@Alex-PLACET
Copy link
Collaborator

Can we merge it ?

@anutosh491
Copy link
Contributor Author

Can we merge it ?

Should be ready I think.

@Alex-PLACET Alex-PLACET merged commit c873784 into man-group:main Sep 22, 2025
161 of 163 checks passed
@anutosh491 anutosh491 deleted the emscripten_tests branch September 22, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants