Media mixin: support arbitrary units #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JirkaVebr
force-pushed
the
pr/media-mixin-units
branch
from
7523e84 to
81e5a38
Compare
enzy
reviewed
Jul 29, 2017
Contributor
enzy
left a comment
enzy
left a comment
There was a problem hiding this comment.
Nemíchal bych jednotky a M keyword dohromady. Co to spíše předřadit? M120em
Contributor
Author
|
Jenže tím by se vše úplně extrémně zesložitilo. Zatímco |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admittedly, this is a bit sorcerous but I couldn't think of any other way to keep the
Mmagic whilst also extending support to arbitrary units of length. Constructive suggestions welcome. At any rate, it is backwards compatible, and thus should be safe to merge.