-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for different templates and upgrade to Angular 12 #29
Conversation
I believe this is because schematics-utilities doesn't support Angular 12. If I change to use Angular CDK instead, it's a similar error. |
@manfredsteyer Are you OK with the changes in e417492? This makes it so the generated code more closely aligns with what I'd expect. It also represents the changes I made in Build Beautiful Angular Apps with Bootstrap. |
@manfredsteyer I decided to keep your theme as a set of templates referred to as |
It probably makes sense to create demos for each framework (bootstrap, material, and paper-dashboard). Could require a few hours of work but will likely result in higher quality. |
I added demos for Bootstrap and Angular Material. However, this is still more work to do. I need to figure out why the navbar doesn't show up in the origin demo. Once I get it working there, I'll try to get it working with the other examples. There's also an issue with Angular Material where the height of the page is not dynamically calculated and the form's width is not calculated. Update: I posted a question to Stack Overflow asking how to fix the dynamic height issue. |
Can't get dropdown working, not sure why
@manfredsteyer I updated the original demo to use Bootstrap 5 and fixed the navbar issue. I don't think the other demos really need the navbar, so I didn't include it. I'll QA this tomorrow (Monday) and it should be ready for a release shortly after. |
Fixes #23.