[Bots] Answer raid role checks - #322
Merged
Merged
Conversation
|
✅ Build Mangos THREE Server 22.03.440 completed (commit 9ceb7e27a0 by @r-log) |
A bot has no role-poll popup, so SMSG_ROLE_POLL_BEGIN went unanswered and the raid's tank/healer/damage counters never counted any bot. Bots now reply with the role implied by the strategy they are already running, which is the same source IsTank()/IsHeal() read.
r-log
force-pushed
the
feat/bots-answer-role-check
branch
from
August 6, 2026 01:04
b1a117f to
5d47fe2
Compare
|
✅ Build Mangos THREE Server 22.03.442 completed (commit d56e717205 by @r-log) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #320 for
SMSG_ROLE_POLL_BEGINandGroup::SetLfgRoles.Bots already receive the role poll —
Group::BroadcastPacketsends to every memberwith a session — they just ignored it. Since a bot has no popup to click, it answers
from the strategy it is already running (
STRATEGY_TYPE_TANK/STRATEGY_TYPE_HEAL),the same source
IsTank()/IsHeal()read, so the reported role matches how the botactually plays.
Without this the tank/healer/damage counters never count any bot, because roles only
reach the client through
SMSG_GROUP_LISTand a bot never set one.Builds clean with
PLAYERBOTS=1; the file is not compiled withPLAYERBOTS=0.This change is