Add renewal grace period for auto-renewing memberships#3698
Merged
IanPhilips merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
The renewal scheduler runs once daily at 8 AM UTC, but getUserSupporterTier() used a strict expiration check. This meant auto-renewing members could appear as lapsed for up to ~24 hours between their expiry and the next scheduler run — even though the scheduler would charge them and renew normally. This adds a 25-hour grace period to the tier check functions so that memberships with autoRenew=true are still treated as active while awaiting the scheduler. This is purely a read-time interpretation — no database or scheduler changes. The scheduler still renews from NOW(), so users aren't getting extra time; they just don't lose benefits during the gap. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The renewal scheduler runs once daily at 8 AM UTC, but getUserSupporterTier() used a strict expiration check. This meant auto-renewing members could appear as lapsed for up to ~24 hours between their expiry and the next scheduler run — even though the scheduler would charge them and renew normally.
This adds a 25-hour grace period to the tier check functions so that memberships with autoRenew=true are still treated as active while awaiting the scheduler. This is purely a read-time interpretation — no database or scheduler changes. The scheduler still renews from NOW(), so users aren't getting extra time; they just don't lose benefits during the gap.