Merged
Conversation
After deleting a spammer's comments, delete their notifications from affected users (market followers + market creators) from the last 3 days. Time-bounded to avoid scanning the full notifications table. Wrapped in try/catch so failures won't break the rest of superban.
- Changed notification cleanup from await to fire-and-forget so superban returns immediately (was causing 10-15min hangs on prolific spammers) - Added early return if user already has all 3 ban types active to prevent redundant cleanup runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverted the original PR because the notification cleanup query blocked the superban response for 10-15min on prolific spammers. This is the same code but fire-and-forget (non-blocking), plus an early return guard to prevent duplicate runs.
This also means you can no longer superban an already banned user (to prevent notification search query spam)