Fix RangeError in announcement post notifications#3708
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Announcement posts notify all users (100k+). The bulkInsert function
tried to build a single INSERT query for all rows, exceeding JS's max
string length and crashing with "RangeError: Invalid string length".
Changes:
- bulkInsert() now chunks values into batches of 1000 rows to avoid
generating queries that exceed the JS string length limit
- Hoist richTextToString() call out of the per-user loop (was being
called 100k+ times redundantly for announcements)
- Truncate announcement sourceText to 200 chars (was unbounded, unlike
the non-announcement path)
Error from logs:
RangeError: Invalid string length
at Array.join (<anonymous>)
at Object.insert (pg-promise/lib/helpers/methods/insert.js:141:12)
at bulkInsertQuery (backend/shared/src/supabase/utils.ts:40:29)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
todwadd
force-pushed
the
fix/bulk-insert-announcement-notifications
branch
from
a44f8b1 to
d7e6c1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Announcement posts notify all users (100k+). The bulkInsert function tried to build a single INSERT query for all rows, exceeding JS's max string length and crashing with "RangeError: Invalid string length".
Changes:
Error from logs:
RangeError: Invalid string length at Array.join () at Object.insert (pg-promise/lib/helpers/methods/insert.js:141:12) at bulkInsertQuery (backend/shared/src/supabase/utils.ts:40:29)