ci: add minimal lint/typecheck floor for the monorepo - #2
Open
maonakamoto wants to merge 1 commit into
Open
Conversation
Adds a CI floor so the scaffold can't rot, without introducing a test suite. - Add root `verify` script (SSOT): builds the shared types package, then type-checks every backend service and the frontend. - Add `typecheck` script to the frontend (tsc --noEmit). - Make root lint/typecheck/clean workspace scripts use `--if-present`. - Add `.github/workflows/ci.yml` running `npm run verify` on push/PR (Node 20). - Refresh root package-lock.json (was out of sync, so `npm ci` can succeed). Scope notes (documented in ci.yml): lint is not gated yet — services ship no ESLint config and the frontend's eslint-config-next@16 / eslint@9 / next@14 combo crashes ESLint; wiring lint needs dependency changes. Running the services / E2E needs docker-compose + Postgres + Redis infra, so it's out of scope for this compile/type floor. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a minimal CI floor so this microservice scaffold can't rot — a compile/type gate only, no test suite introduced.
Repo shape
npm-workspaces monorepo: 4 backend services (
services/api-gateway,matching,notification,reporting) +shared/types(all TS), plus a standalone Next.jsfrontend/(its own lockfile, not a workspace).Changes (additive, low-risk)
verifyscript (root, SSOT) — buildsshared/types, then type-checks every service and the frontend. Ordered because services import the shared package via its builtdist/index.d.ts.frontendtypecheckscript —tsc --noEmit(the frontend had none).lint/typecheck/cleanworkspace scripts now use--if-present..github/workflows/ci.yml— runsnpm run verifyon push/PR (Node 20 LTS). CI runs the same SSOT script, so local green == CI green.package-lock.jsonrefreshed — root lock was out of sync withpackage.json; regenerated so CInpm cisucceeds.Intentionally NOT gated (needs a human/dependency decision)
eslintdep). The frontend'seslint-config-next@16+eslint@9+next@14combination currently crashes ESLint (Converting circular structure to JSON), andnext lint(Next 14) drops into an interactive setup prompt against the flat config. Wiring lint requires dependency changes, out of scope for an additive floor.Verification
All constituent steps pass locally (each
tscexited 0: shared/types build, all 5 workspace type-checks, frontend type-check). CI is the authoritative gate.🤖 Generated with Claude Code