Skip to content

New query parameter, waypoint names added to directions options. #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Add Options to JSON Encoder in RouteResponse
merged 1 commit into from
May 9, 2018
Merged

New query parameter, waypoint names added to directions options. #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions MapboxDirections/MBDirectionsOptions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,11 @@ open class DirectionsOptions: NSObject, NSSecureCoding, NSCopying {
params.append(URLQueryItem(name: "annotations", value: attributesStrings))
}

if !waypoints.compactMap({ $0.name }).isEmpty {
let names = waypoints.map { $0.name ?? "" }.joined(separator: ";")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to do this map and compactMap once?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because an intermediate waypoint can have no name, but it would still need an empty entry in the semicolon-delimited list.

params.append(URLQueryItem(name: "waypoint_names", value: names))
}

return params
}
}
Expand Down
Loading