Respect marker and flyTo options when geolocating #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the geolocation feature (added in #444) adds a marker to the map and flies the map to the new location, even if the
markerandflyTooptions are set tofalse. This PR changes that behavior to be consistent withquery(). I also performed some minor cleanup on some of the related tests, and removed some hanging whitespace.I considered further DRYing those option checks and moving them into
_handleMarker()and_fly(), but decided to keep that a concern of the caller, rather than those functions themselves. I don't feel strongly about it either way, though.masterheading before merging