Make NavigationService optional.
#3223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximAlien
added
bug
MaximAlien
force-pushed
the
maxim/revert-incorrectly-added-car-play-manager-delegate-changes
branch
2 times, most recently
from
7464a50 to
ac4c8a3
Compare
…f delegate method on client side as `CarPlayManager` provides default `MapboxNavigationService` implementation anyway.
MaximAlien
force-pushed
the
maxim/revert-incorrectly-added-car-play-manager-delegate-changes
branch
from
a3599ca to
d1f496c
Compare
ShanMa1991
approved these changes
Aug 4, 2021
MaximAlien
deleted the
maxim/revert-incorrectly-added-car-play-manager-delegate-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3182 incorrectly reverted some of the changes, which were brought by #3208. Current PR brings these changes back.