Promotes Variant to mapbox:: Namespace — Closes #104 #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a future version we want to remove the `mapbox::util::` namespace. Until then we provide both adding a deprecation warning to the readme. Implementation detail: we make the util namespace an `inline` namespace - otherwise users could notice us changing the specific namespace in which our templates were declared in. The downside here is we can't add a deprecation pragma since then the `mapbox::` namespace would contain it, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #104 - cc @artemp @jfirebaugh
In a future version we want to remove the
mapbox::util::namespace. Until then we provide both adding a deprecation
warning to the readme.
Implementation detail: we make the util namespace an
inlinenamespace - otherwise users could notice us changing the
specific namespace in which our templates were declared in.
The downside here is we can't add a deprecation pragma since
then the
mapbox::namespace would contain it, too.