1.1.1 fix permissions on pdf's display

ChangeLog.md

@@ -1,5 +1,18 @@
 # CHANGELOG MODULE TIMESHEETWEEK FOR [DOLIBARR ERP CRM](https://www.dolibarr.org)
 
+## 1.1.1
+- Mise à "plat" des permissions pour régler un problème d'affichage des PDF. / "Flattening" permissions to fix a PDF display issue.
+
+## 1.1.0
+- Ajoute la massaction « Générer le PDF de synthèse » afin de produire un récapitulatif multi-salariés dans un PDF conforme aux standards Dolibarr. / Adds the "Generate summary PDF" mass action to produce a multi-employee PDF recap compliant with Dolibarr standards.
+
+## 1.0.7
+- Harmonise les pictogrammes d'approbation et de refus avec les icônes Dolibarr natives. / Harmonises the approval and refusal pictograms with native Dolibarr icons.
+- Ajoute la massaction « Sceller » et applique les contrôles de permissions Dolibarr aux actions de masse. / Adds the "Seal" mass action and applies Dolibarr permission checks to bulk operations.
+- Limite la suppression massive aux feuilles en brouillon et avertit en cas de sélection invalide. / Restricts bulk deletion to draft sheets and warns when invalid selections are detected.
+- Complète les traductions de la liste pour les actions de masse. / Completes list translations for bulk actions.
+
+
 ## 1.0.6
 - Réorganise le menu gauche pour afficher « Nouvelle feuille » avant « Liste ». / Reorders the left menu to display "New sheet" before "List".
 - Ajoute les entrées « TimesheetWeek » dans les menus principaux Agenda et Projet. / Adds the "TimesheetWeek" entries under the Agenda and Project main menus.
@@ -31,6 +44,10 @@
 - Corrige un problème dans les options de partage du module "Multicompany". / Fixes an issue in the "Multicompany" module sharing options.
 - Repositionne les totaux correctement. / Correctly repositions totals.
 - Inversion de position de "Nouvelle Feuille d'heure" et "Liste" dans le menu gauche. / Swaps the position of "New Timesheet" and "List" in the left menu.
+- Le tableau du PDF de synthèse occupe désormais toute la largeur imprimable pour une meilleure lisibilité. / Summary PDF table now spans the full printable width for improved readability.
+- Ajoute les entêtes et pieds de page standards à chaque page du PDF de synthèse et garantit que le premier tableau débute dès la première page. / Adds standard headers and footers to every summary PDF page and ensures the first table starts on the opening page.
+- Remonte le pied de page du PDF de synthèse pour réduire la marge basse et améliorer la lisibilité. / Raises the summary PDF footer to reduce the bottom margin and improve readability.
+- Garantit que le contenu du PDF de synthèse reste entre l'entête et le pied de page sur chaque feuille. / Ensures the summary PDF content stays between the header and footer on every sheet.
 - Corrige un problème pouvant masquer les tâches clôturées dans les Fiches passées. / Fix an issue that could hide closed tasks in passed timesheet.
 
 ## 1.0.1

ajax/timesheetweek.php

@@ -76,9 +76,9 @@
 
 // EN: Evaluate write permissions, including subordinate scope, before processing the request.
 // FR: Évalue les permissions d'écriture, y compris sur les subordonnés, avant de traiter la requête.
-$permWrite = $user->hasRight('timesheetweek', 'timesheetweek', 'write');
-$permWriteChild = $user->hasRight('timesheetweek', 'timesheetweek', 'writeChild');
-$permWriteAll = $user->hasRight('timesheetweek', 'timesheetweek', 'writeAll');
+$permWrite = $user->hasRight('timesheetweek', 'write');
+$permWriteChild = $user->hasRight('timesheetweek', 'writeChild');
+$permWriteAll = $user->hasRight('timesheetweek', 'writeAll');
 $canWriteAll = (!empty($user->admin) || $permWriteAll);
 if (!($permWrite || $permWriteChild || $canWriteAll)) {
 	// EN: Return a JSON 403 response when the user cannot edit any timesheet.

class/actions_timesheetweek.class.php

@@ -69,7 +69,7 @@ public function menuDropdownQuickaddItems($parameters, &$object, &$action, $hook
         // EN: Evaluate user permissions to control quick creation visibility.
         // FR: Évaluer les droits de l'utilisateur pour contrôler la visibilité de la création rapide.
 
-        $hasWriteRight = $user->hasRight('timesheetweek', 'timesheetweek', 'write') || $user->hasRight('timesheetweek', 'timesheetweek', 'writeChild') || $user->hasRight('timesheetweek', 'timesheetweek', 'writeAll');
+        $hasWriteRight = $user->hasRight('timesheetweek', 'write') || $user->hasRight('timesheetweek', 'writeChild') || $user->hasRight('timesheetweek', 'writeAll');
 
         // EN: Inject the quick creation entry with translated metadata.
         // FR: Injecter l'entrée de création rapide avec des métadonnées traduites.

core/modules/modTimesheetWeek.class.php

@@ -80,8 +80,8 @@ public function __construct($db)
 		$this->editor_squarred_logo = '';					// Must be image filename into the module/img directory followed with @modulename. Example: 'myimage.png@timesheetweek'
 
 		// Possible values for version are: 'development', 'experimental', 'dolibarr', 'dolibarr_deprecated', 'experimental_deprecated' or a version string like 'x.y.z'
-		$this->version = '1.0.6'; // EN: Reorders the left menu, adds agenda and project menu entries and fixes the list page limit selector.
-		// FR: Réorganise le menu gauche, ajoute les entrées de menus agenda et projet et corrige le sélecteur de limite dans la liste.
+		$this->version = '1.1.1'; 	// EN: "Flattening" permissions to fix a PDF display issue.
+									// FR: Mise à "plat" des permissions pour régler un problème d'affichage des PDF.
 		// Url to the file with your last numberversion of this module
 		//$this->url_last_version = 'http://www.example.com/versionmodule.txt';
 
@@ -305,96 +305,110 @@ public function __construct($db)
 		/* BEGIN MODULEBUILDER PERMISSIONS */
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 0 + 1);
         $this->rights[$r][1] = $langs->trans('TimesheetWeekRightReadOwn');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'read';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'read';
+		$this->rights[$r][5] = '';
 		$r++;
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 1 + 1);
         $this->rights[$r][1] = $langs->trans('TimesheetWeekRightReadChild');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'readChild';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'readChild';
+		$this->rights[$r][5] = '';
 		$r++;
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 2 + 1);
         $this->rights[$r][1] = $langs->trans('TimesheetWeekRightReadAll');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'readAll';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'readAll';
+		$this->rights[$r][5] = '';
 		$r++;
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 3 + 1);
         $this->rights[$r][1] = $langs->trans('TimesheetWeekRightWriteOwn');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'write';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'write';
+		$this->rights[$r][5] = '';
 		$r++;
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 4 + 1);
         $this->rights[$r][1] = $langs->trans('TimesheetWeekRightWriteChild');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'writeChild';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'writeChild';
+		$this->rights[$r][5] = '';
 		$r++;
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 5 + 1);
         $this->rights[$r][1] = $langs->trans('TimesheetWeekRightWriteAll');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'writeAll';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'writeAll';
+		$this->rights[$r][5] = '';
 		$r++;
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 6 + 1);
         $this->rights[$r][1] = $langs->trans('TimesheetWeekRightDeleteOwn');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'delete';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'delete';
+		$this->rights[$r][5] = '';
 		$r++;
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 7 + 1);
         $this->rights[$r][1] = $langs->trans('TimesheetWeekRightDeleteChild');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'deleteChild';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'deleteChild';
+		$this->rights[$r][5] = '';
 		$r++;
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 8 + 1);
 		$this->rights[$r][1] = $langs->trans('TimesheetWeekRightDeleteAll');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'deleteAll';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'deleteAll';
+		$this->rights[$r][5] = '';
 		$r++;
 		// EN: Legacy validation permission kept for backward compatibility
 		// FR : Droit de validation générique conservé pour compatibilité ascendante
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 9 + 1);
 		$this->rights[$r][1] = $langs->trans('TimesheetWeekRightValidateGeneric');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'validate';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'validate';
+		$this->rights[$r][5] = '';
 		$r++;
 		// EN: Allow managers to validate their own timesheets only
 		// FR : Autorise un utilisateur à valider uniquement ses propres feuilles
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 10 + 1);
 		$this->rights[$r][1] = $langs->trans('TimesheetWeekRightValidateOwn');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'validateOwn';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'validateOwn';
+		$this->rights[$r][5] = '';
 		$r++;
 		// EN: Allow validation on subordinate timesheets
 		// FR : Autorise la validation des feuilles des subordonnés
 		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 11 + 1);
 		$this->rights[$r][1] = $langs->trans('TimesheetWeekRightValidateChild');
-		$this->rights[$r][4] = 'timesheetweek';
-		$this->rights[$r][5] = 'validateChild';
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'validateChild';
+		$this->rights[$r][5] = '';
+		$r++;
+		// EN: Allow global validation on all employee timesheets
+		// FR : Autorise la validation de toutes les feuilles de temps
+		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 12 + 1);
+		$this->rights[$r][1] = $langs->trans('TimesheetWeekRightValidateAll');
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'validateAll';
+		$this->rights[$r][5] = '';
+		$r++;
+
+		// EN: Allow sealing approved timesheets.
+		// FR : Autorise le scellement des feuilles approuvées.
+		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 13 + 1);
+		$this->rights[$r][1] = $langs->trans('TimesheetWeekRightSeal');
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'seal';
+		$this->rights[$r][5] = '';
+		$r++;
+
+		// EN: Allow reopening sealed timesheets.
+		// FR : Autorise le descellage des feuilles scellées.
+		$this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 14 + 1);
+		$this->rights[$r][1] = $langs->trans('TimesheetWeekRightUnseal');
+		$this->rights[$r][3] = 0;
+		$this->rights[$r][4] = 'unseal';
+		$this->rights[$r][5] = '';
 		$r++;
-                // EN: Allow global validation on all employee timesheets
-                // FR : Autorise la validation de toutes les feuilles de temps
-                $this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 12 + 1);
-                $this->rights[$r][1] = $langs->trans('TimesheetWeekRightValidateAll');
-                $this->rights[$r][4] = 'timesheetweek';
-                $this->rights[$r][5] = 'validateAll';
-                $r++;
-
-                // EN: Allow sealing approved timesheets.
-                // FR : Autorise le scellement des feuilles approuvées.
-                $this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 13 + 1);
-                $this->rights[$r][1] = $langs->trans('TimesheetWeekRightSeal');
-                $this->rights[$r][4] = 'timesheetweek';
-                $this->rights[$r][5] = 'seal';
-                $r++;
-
-                // EN: Allow reopening sealed timesheets.
-                // FR : Autorise le descellage des feuilles scellées.
-                $this->rights[$r][0] = $this->numero . sprintf('%02d', (0 * 10) + 14 + 1);
-                $this->rights[$r][1] = $langs->trans('TimesheetWeekRightUnseal');
-                $this->rights[$r][4] = 'timesheetweek';
-                $this->rights[$r][5] = 'unseal';
-                $r++;
-
-                /* END MODULEBUILDER PERMISSIONS */
 
+		/* END MODULEBUILDER PERMISSIONS */
 
 		// Main menu entries to add
 		$this->menu = array();
@@ -413,7 +427,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek', // Lang file to use (without .lang) by module. File must be in langs/code_CODE/ directory.
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")', // Define condition to show or hide menu entry. Use 'isModEnabled("timesheetweek")' if entry must be visible if module is enabled.
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "read")', // Use 'perms'=>'$user->hasRight("timesheetweek", "timesheetweek", "read")' if you want your menu with a permission rules
+			'perms' => '$user->hasRight("timesheetweek", "read")', // Use 'perms'=>'$user->hasRight("timesheetweek", "read")' if you want your menu with a permission rules
 			'target' => '',
 			'user' => 2, // 0=Menu for internal users, 1=external users, 2=both
 		);
@@ -452,7 +466,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")',
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "read")',
+			'perms' => '$user->hasRight("timesheetweek", "read")',
 			'target' => '',
 			'user' => 2,
 			'object' => 'TimesheetWeek'
@@ -467,7 +481,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")',
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "write")',
+			'perms' => '$user->hasRight("timesheetweek", "write")',
 			'target' => '',
 			'user' => 2,
 			'object' => 'TimesheetWeek'
@@ -482,7 +496,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")',
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "read")',
+			'perms' => '$user->hasRight("timesheetweek", "read")',
 			'target' => '',
 			'user' => 2,
 			'object' => 'TimesheetWeek'
@@ -500,7 +514,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")',
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "read")',
+			'perms' => '$user->hasRight("timesheetweek", "read")',
 			'target' => '',
 			'user' => 2,
 			'object' => 'TimesheetWeek'
@@ -515,7 +529,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")',
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "write")',
+			'perms' => '$user->hasRight("timesheetweek", "write")',
 			'target' => '',
 			'user' => 2,
 			'object' => 'TimesheetWeek'
@@ -530,7 +544,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")',
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "read")',
+			'perms' => '$user->hasRight("timesheetweek", "read")',
 			'target' => '',
 			'user' => 2,
 			'object' => 'TimesheetWeek'
@@ -549,7 +563,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")',
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "read")',
+			'perms' => '$user->hasRight("timesheetweek", "read")',
 			'target' => '',
 			'user' => 2,
 			'object' => 'TimesheetWeek'
@@ -564,7 +578,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")',
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "write")',
+			'perms' => '$user->hasRight("timesheetweek", "write")',
 			'target' => '',
 			'user' => 2,
 			'object' => 'TimesheetWeek'
@@ -579,7 +593,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")',
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "read")',
+			'perms' => '$user->hasRight("timesheetweek", "read")',
 			'target' => '',
 			'user' => 2,
 			'object' => 'TimesheetWeek'
@@ -599,7 +613,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',	        // Lang file to use (without .lang) by module. File must be in langs/code_CODE/ directory.
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")', // Define condition to show or hide menu entry. Use 'isModEnabled("timesheetweek")' if entry must be visible if module is enabled.
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "read")',
+			'perms' => '$user->hasRight("timesheetweek", "read")',
 			'target' => '',
 			'user' => 2,				                // 0=Menu for internal users, 1=external users, 2=both
 			'object' => 'TimesheetWeek'
@@ -614,7 +628,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',	        // Lang file to use (without .lang) by module. File must be in langs/code_CODE/ directory.
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")', // Define condition to show or hide menu entry. Use 'isModEnabled("timesheetweek")' if entry must be visible if module is enabled. Use '$leftmenu==\'system\'' to show if leftmenu system is selected.
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "write")'
+			'perms' => '$user->hasRight("timesheetweek", "write")'
 			'target' => '',
 			'user' => 2,				                // 0=Menu for internal users, 1=external users, 2=both
 			'object' => 'TimesheetWeek'
@@ -629,7 +643,7 @@ public function __construct($db)
 			'langs' => 'timesheetweek@timesheetweek',	        // Lang file to use (without .lang) by module. File must be in langs/code_CODE/ directory.
 			'position' => 1000 + $r,
 			'enabled' => 'isModEnabled("timesheetweek")', // Define condition to show or hide menu entry. Use 'isModEnabled("timesheetweek")' if entry must be visible if module is enabled.
-			'perms' => '$user->hasRight("timesheetweek", "timesheetweek", "read")'
+			'perms' => '$user->hasRight("timesheetweek", "read")'
 			'target' => '',
 			'user' => 2,				                // 0=Menu for internal users, 1=external users, 2=both
 			'object' => 'TimesheetWeek'