chore: add a bench and render tests for tesselation - #7894
Open
CommanderStorm wants to merge 11 commits into
Open
chore: add a bench and render tests for tesselation#7894CommanderStorm wants to merge 11 commits into
CommanderStorm wants to merge 11 commits into
Conversation
CommanderStorm
force-pushed
the
tesselation-workup
branch
from
July 8, 2026 11:52
6a774cf to
c1870c0
Compare
CommanderStorm
marked this pull request as draft
July 8, 2026 11:54
CommanderStorm
force-pushed
the
tesselation-workup
branch
from
July 8, 2026 12:12
c1870c0 to
abfd660
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7894 +/- ##
=======================================
Coverage 93.20% 93.21%
=======================================
Files 290 290
Lines 24620 24620
Branches 6475 6475
=======================================
+ Hits 22948 22949 +1
+ Misses 1672 1671 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CommanderStorm
commented
Jul 8, 2026
Member
Author
There was a problem hiding this comment.
need to be reencoded using the rust encoder because otherwise they are very weird (early java enoder I guess) and also not a good benchmark in comparison to the smaller, tesselated tiles
Updated comments for clarity and conciseness in MLTParse options and class.
CommanderStorm
marked this pull request as ready for review
July 8, 2026 13:21
HarelM
reviewed
Jul 12, 2026
CommanderStorm
commented
Jul 12, 2026
HarelM
approved these changes
Jul 23, 2026
Collaborator
|
It looks like there's a problem reading the updated tile, I'm guessing it's a bug in the ts version of the mlt parser. |
CommanderStorm
enabled auto-merge (squash)
July 28, 2026 21:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used claude to add one tesselation benchmark and respective render tests.
Because we currently just ignore the extra tesselation (in fact, we currently ONLY have tesselated render tests) adding this is worthwile anyhow.
Also slims the tesselation PR a bit.