Skip to content

chore: add a bench and render tests for tesselation - #7894

Open
CommanderStorm wants to merge 11 commits into
maplibre:mainfrom
CommanderStorm:tesselation-workup
Open

chore: add a bench and render tests for tesselation#7894
CommanderStorm wants to merge 11 commits into
maplibre:mainfrom
CommanderStorm:tesselation-workup

Conversation

@CommanderStorm

Copy link
Copy Markdown
Member

I used claude to add one tesselation benchmark and respective render tests.

Because we currently just ignore the extra tesselation (in fact, we currently ONLY have tesselated render tests) adding this is worthwile anyhow.

Also slims the tesselation PR a bit.

@CommanderStorm
CommanderStorm marked this pull request as draft July 8, 2026 11:54
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.21%. Comparing base (354aa07) to head (abfd660).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7894   +/-   ##
=======================================
  Coverage   93.20%   93.21%           
=======================================
  Files         290      290           
  Lines       24620    24620           
  Branches     6475     6475           
=======================================
+ Hits        22948    22949    +1     
+ Misses       1672     1671    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CommanderStorm CommanderStorm Jul 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to be reencoded using the rust encoder because otherwise they are very weird (early java enoder I guess) and also not a good benchmark in comparison to the smaller, tesselated tiles

Updated comments for clarity and conciseness in MLTParse options and class.
@CommanderStorm
CommanderStorm marked this pull request as ready for review July 8, 2026 13:21
@CommanderStorm
CommanderStorm requested a review from HarelM July 8, 2026 13:21
Comment thread test/bench/versions/index.ts Outdated
Comment thread test/bench/versions/index.ts Outdated
@CommanderStorm
CommanderStorm requested a review from HarelM July 14, 2026 11:09
@HarelM

HarelM commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

It looks like there's a problem reading the updated tile, I'm guessing it's a bug in the ts version of the mlt parser.
Let me know how I can help. Once CI passes this can be merged.

@CommanderStorm
CommanderStorm enabled auto-merge (squash) July 28, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants