Passing tile data to CustomLayer class - #7913
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7913 +/- ##
==========================================
+ Coverage 93.19% 93.23% +0.04%
==========================================
Files 290 290
Lines 24652 24669 +17
Branches 6478 6484 +6
==========================================
+ Hits 22975 23001 +26
+ Misses 1677 1668 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for taking the time to open this PR! Sharing a design document for this feature can be helpful I believe. |
|
Ping me when this is ready for review, currently in draft mode. |
|
@HarelM sorry for late, and thank you for response! |
|
Looking at the code, it seems that this re-parses the tiles data before handing them. Let me know if I'm missing anything. Sorry for the delay in response. |
|
Thanks! I understand I can workaround in any way. |
Close #1305
Motivation
Recently I did experiment to render 3d models with lod aspects in GL JS.
Then I realized if custom layer can get tile data directly, codes would become more simpler and performance would be better by less copy. I remember some years ago I tried passing tile data to custom layer and now implement this.
Launch Checklist
CHANGELOG.mdunder the## mainsection.Benchmark
AI usage disclosure
Codex GPT 5.6 Sol