Report worker script failures through map error events - #8156
Closed
NearlCrews wants to merge 1 commit into
Closed
Conversation
Author
|
Disclosure per the project contribution policy: Generated-By: OpenAI Codex (GPT-5). |
NearlCrews
force-pushed
the
fix/report-worker-load-errors
branch
from
August 12, 2026 10:22
98d34d7 to
97ef769
Compare
Collaborator
|
Make sure that there's no open PR on this already when using AI. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8156 +/- ##
==========================================
- Coverage 93.28% 93.28% -0.01%
==========================================
Files 301 301
Lines 25081 25104 +23
Branches 6578 6582 +4
==========================================
+ Hits 23397 23418 +21
- Misses 1684 1686 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
You are right. I missed #8024 before opening this. I compared the implementations: this branch leaves WorkerPool unchanged and attaches error and messageerror listeners in Dispatcher, but it still overlaps the same issue. I am closing it to avoid duplicate review. The all-green branch remains available if the narrower approach is useful for #8024. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
errorandmessageerrorevents through the dispatcher to the mapFixes #8018.
Verification
git diff --checkLaunch Checklist
CHANGELOG.mdentry is included.