chore: exclude benchmark files from coverage reports - #8159
Merged
HarelM merged 1 commit intoAug 12, 2026
Conversation
HarelM
approved these changes
Aug 12, 2026
HarelM
enabled auto-merge (squash)
August 12, 2026 15:21
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8159 +/- ##
==========================================
+ Coverage 93.28% 93.93% +0.65%
==========================================
Files 301 290 -11
Lines 25081 24905 -176
Branches 6578 6569 -9
==========================================
- Hits 23397 23395 -2
+ Misses 1684 1510 -174 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With benchmarks living next to the code as
src/**/*.bench.ts, the coverage config picks them up as source. They only run undervitest bench, which collects no coverage, so they can never report anything but 0% — every PR that adds one gets a red patch-coverage comment that no test can fix (#8127 read 0% patch with 88 lines "missing" for exactly this reason, and the bench file is all that keeps #8158's comment red today). This excludes them from the unit and integration coverage reports the same way**/*.test.tsalready is, so the patch number reflects testable code again.Launch Checklist