Keep symbol visible if elevated symbol is line-of-sight - #8164
Open
birkskyum wants to merge 3 commits into
Open
Conversation
Collaborator
|
Thanks! I think this PR makes sense. Let me finish up the style-spec changes, push them and then review and merge this. |
Member
Author
|
I didn't really capture it in the above video, but the behavior of this PR is that the symbol can still be "behind" terrain, as one would expect it to. Like in the video here, teh "bird" is far away, and some nearby mountains block it. Screen.Recording.2026-08-13.at.20.17.50.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think elevated symbols should remain visible when their ground position is occluded, as long as the elevated symbol itself is still visible. With the current behavior, a terrain ridge can make an airborne symbol disappear even though it remains above the ridge and in the camera’s line of sight.
This PR changes that to make the symbol stay visible, which seems like the most intuitive behavior for either proposed
symbol-height-anchormodes:groundorabsolute, to avoid a lot of icon flickering.Left - What's on the symbol-elevation branch right now.
Right - This PR
Screen.Recording.2026-08-13.at.19.26.35.mov