Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a simple pipeline unit test without mara db #71

Merged
merged 4 commits into from
May 13, 2022
Merged

Conversation

leo-schick
Copy link
Member

Adds a simple unit test for a pipeline execution. To do so I changed the code that the 'mara' db is optional during the pipeline execution:

  • node cost is not taken from the database
  • RunLogger will skip logging events to the database when 'mara' database is not defined

@leo-schick leo-schick requested a review from jankatins May 10, 2022 09:40
Copy link
Member

@jankatins jankatins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see a big warning printed when mara db is not there, but otherwise LGTM

@leo-schick leo-schick requested a review from jankatins May 11, 2022 05:49
@leo-schick leo-schick requested a review from jankatins May 13, 2022 11:33
@leo-schick leo-schick changed the base branch from master to 3.2.x May 13, 2022 12:41
@leo-schick leo-schick merged commit 4ec05ed into 3.2.x May 13, 2022
@leo-schick leo-schick deleted the test-pipeline branch September 22, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants