Skip to content

Expires time is calculated twice when using expires_in and can cause signature authentication problems #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loe wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Expires time is calculated twice when using expires_in and can cause signature authentication problems #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40a4dd0
Memoize the expires time.
loe Feb 1, 2012
a7aedc3
Style.
loe Feb 1, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/aws/s3/authentication.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def initialize(*args)
# 3) The current time in seconds since the epoch plus the default number of seconds (60 seconds)
def expires
return options[:expires] if options[:expires]
date.to_i + expires_in
@expires ||= date.to_i + expires_in
end

def expires_in
Expand Down Expand Up @@ -218,4 +218,4 @@ def only_path
end
end
end
end
end