Add format and mix parameters to MonitorAction.php #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Syco <syco@echo>
marcelog
requested changes
Dec 9, 2017
| * @return void | ||
| */ | ||
| public function __construct($channel, $filename) | ||
| public function __construct($channel, $filename, $format = 'wav', $mix = 'true') |
There was a problem hiding this comment.
IMO, If these are not required to create this action, they should be set with setters, like we do in other actions
added 3 commits
November 21, 2018 13:37
Signed-off-by: Syco <syco@torann>
Signed-off-by: Syco <syco@torann>
Signed-off-by: Syco <syco@torann>
dkgroot
added a commit
to chan-sccp/PAMI
that referenced
this pull request
Apr 24, 2019
Add format and mix parameters to MonitorAction.php Small fix to follow to marcelogs directive PR: Created by @syco (marcelog#149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've extended monitor action with 2 more parameters, please consider including it in the main repo.
Thanks.