-
Notifications
You must be signed in to change notification settings - Fork 4
Add search toggles #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcodejongh
wants to merge
2
commits into
main
Choose a base branch
from
add_search_toggles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add search toggles #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
565ea50
to
629b943
Compare
marcodejongh
added a commit
that referenced
this pull request
Aug 10, 2025
Updates the search form to use the improved UI pattern from PR #137: - Changed form layout to horizontal with left-aligned labels (14/10 span) - Replaced "Classics Only" dropdown with Switch component - Added Typography.Title for "Personal Progress" section heading - Updated Alert message for better clarity when not logged in - Aligned all switches to the right with consistent styling - Used valuePropName="checked" for proper Switch integration The UI now matches the cleaner, more organized design pattern established in the search toggles PR. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
marcodejongh
added a commit
that referenced
this pull request
Aug 10, 2025
* Add personal progress filters to climb search Implements filtering by climbs already attempted or completed by the logged-in user. ## New Features - Hide Attempted: Filter out climbs the user has attempted - Hide Completed: Filter out climbs the user has completed - Only Attempted: Show only climbs the user has attempted - Only Completed: Show only climbs the user has completed ## Implementation Details - Added new boolean properties to SearchRequest type - Enhanced search form UI with toggle switches (only visible when logged in) - Updated backend queries to join ascents/bids tables when filters are active - Modified API route to handle user authentication headers - Updated data fetching to include auth headers when available - Added URL parameter persistence and analytics tracking - Fixed test files to include new required properties ## Database Integration - Uses EXISTS subqueries for optimal performance - Supports both Kilter and Tension board types - Only applies filters when user is authenticated Addresses issue #110 - good first issue for filtering climbs by user progress. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Improve personal progress filters UI layout Updates the search form to use the improved UI pattern from PR #137: - Changed form layout to horizontal with left-aligned labels (14/10 span) - Replaced "Classics Only" dropdown with Switch component - Added Typography.Title for "Personal Progress" section heading - Updated Alert message for better clarity when not logged in - Aligned all switches to the right with consistent styling - Used valuePropName="checked" for proper Switch integration The UI now matches the cleaner, more organized design pattern established in the search toggles PR. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
marcodejongh
added a commit
that referenced
this pull request
Aug 10, 2025
* Add personal progress filters to climb search Implements filtering by climbs already attempted or completed by the logged-in user. ## New Features - Hide Attempted: Filter out climbs the user has attempted - Hide Completed: Filter out climbs the user has completed - Only Attempted: Show only climbs the user has attempted - Only Completed: Show only climbs the user has completed ## Implementation Details - Added new boolean properties to SearchRequest type - Enhanced search form UI with toggle switches (only visible when logged in) - Updated backend queries to join ascents/bids tables when filters are active - Modified API route to handle user authentication headers - Updated data fetching to include auth headers when available - Added URL parameter persistence and analytics tracking - Fixed test files to include new required properties ## Database Integration - Uses EXISTS subqueries for optimal performance - Supports both Kilter and Tension board types - Only applies filters when user is authenticated Addresses issue #110 - good first issue for filtering climbs by user progress. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Improve personal progress filters UI layout Updates the search form to use the improved UI pattern from PR #137: - Changed form layout to horizontal with left-aligned labels (14/10 span) - Replaced "Classics Only" dropdown with Switch component - Added Typography.Title for "Personal Progress" section heading - Updated Alert message for better clarity when not logged in - Aligned all switches to the right with consistent styling - Used valuePropName="checked" for proper Switch integration The UI now matches the cleaner, more organized design pattern established in the search toggles PR. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Fix heatmap personal progress filtering Updates heatmap to properly respect personal progress filters by adding header-based authentication support. ## Changes - Updated heatmap API route to check for x-auth-token and x-user-id headers - Added fallback to session-based auth for backward compatibility - Modified use-heatmap.tsx hook to include auth headers when user is logged in - Added token and user_id to useEffect dependencies for proper re-fetching ## Behavior - When personal progress filters are active, heatmap API checks headers first - Falls back to session auth if no headers provided - Heatmap now properly filters holds based on user's climb history - Maintains existing functionality for non-authenticated users The heatmap will now correctly hide/show holds from climbs the user has attempted or completed when using the personal progress filters. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.