Add circuit/list filtering support #272
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement comprehensive circuit support with filtering and display features: Features: - Circuit dropdown filter in search form (logged-in users only) - Clickable circuit tags on climb cards with color coding - Circuit filtering integrated with existing search functionality - Support for both user circuits and public circuits Technical Implementation: - Added circuit database queries and API endpoints - Extended search parameters to support circuitUuids filtering - Added circuits_climbs sync to user data sync process - Created custom hooks for fetching circuits and climb circuits - Updated climb search queries to filter by circuit membership - Enhanced UI components with circuit selection and display Database Changes: - Added circuitsClimbs table support to table selection utility - Implemented circuit-climb relationship queries with position ordering - Added circuits_climbs to USER_TABLES for proper syncing UI/UX: - Multi-select circuit dropdown with color indicators - Circuit tags show on climb cards when user is authenticated - Tags are clickable to quickly filter by circuit - Proper loading states and error handling 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Update test files to include the new circuitUuids property in SearchRequestPagination objects: - Fixed use-queue-data-fetching.test.tsx - Fixed reducer.test.ts (2 instances) All TypeScript compilation errors resolved.
Changes: - Made ClimbCard component provider-independent by adding optional onCircuitClick prop - Circuit tags only clickable when callback is provided (in list view) - Added circuit click handler to ClimbsList component with analytics tracking - Circuit tags display but are not clickable in individual climb view (correct behavior) - Resolves 'useUISearchParams must be used within a SearchParamsProvider' error This ensures circuit functionality works properly in both list and individual climb views without requiring all usage contexts to have the UISearchParamsProvider.
The provider was only wrapping the sidebar (TabsWrapper) but ClimbsList component in the main content area also needs access to useUISearchParams for circuit filtering functionality. Moved UISearchParamsProvider to wrap the entire ListLayoutClient so both the sidebar search forms and the main content ClimbsList can access the search parameters context. This resolves the remaining 'useUISearchParams must be used within a SearchParamsProvider' error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features Added
UI Components
Backend Integration
Technical Implementation
circuitUuidsto SearchRequest type and URL parameter handlinguseCircuitsanduseClimbCircuitsfor data fetchingDatabase Changes
User Experience
Test Plan
🤖 Generated with Claude Code