Skip to content

Add no-matching icon for Tension board climbs #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcodejongh
Copy link
Owner

Summary

  • Adds a red stop icon next to climb names on Tension boards when descriptions contain "no matching" patterns
  • Implements the regex pattern \b(?:no|don'?t)\s*match(?:ing)?\b as specified in issue Add No-Matching Icon for Tensionboard #28
  • Icon only appears on Tension board climbs with matching descriptions

Changes Made

  • Added hasNoMatchingPattern() utility function in app/lib/climb-utils.ts
  • Updated climb card component to conditionally render StopOutlined icon
  • Added comprehensive test coverage with 4 test cases covering various patterns
  • Updated TypeScript config to exclude test files from type checking

Test plan

  • Created and ran unit tests for the regex pattern matching
  • Verified TypeScript compilation passes
  • Confirmed ESLint passes without warnings
  • Icon only shows for tension boards (not kilter)
  • Icon appears for descriptions with "no matching", "don't match", "no match", etc.
  • Icon does not appear for normal descriptions

Fixes #28

🤖 Generated with Claude Code

Adds a red stop icon next to climb names on Tension boards when the
description contains "no matching" patterns. Resolves issue #28.

- Added hasNoMatchingPattern() utility with case-insensitive regex
- Updated climb card component to show StopOutlined icon conditionally
- Added comprehensive test coverage for the utility function
- Updated TypeScript config to exclude test files from checking

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link

vercel bot commented Aug 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boardsesh ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2025 1:51am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add No-Matching Icon for Tensionboard
1 participant