Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set vaadin.pnpm.enable = true #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msabramo
Copy link

@msabramo msabramo commented Jun 29, 2022

Without this, when I start the app, npm runs and pnpm-lock.yaml is
ignored and actually gets deleted and a package-lock.json is generated:

$ git status
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   .factorypath
        deleted:    pnpm-lock.yaml

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        package-lock.json

I think this results in getting an incorrect set of package versions,
because I get a TypeScript compile error about IReactionOptions in
frontend/view.ts:

ERROR in /Users/abramowi/learn/mobx/vaadin-fusion-mobx/frontend/view.ts
./view.ts
[tsl] ERROR in /Users/abramowi/learn/mobx/vaadin-fusion-mobx/frontend/view.ts(22,12)
      TS2314: Generic type 'IReactionOptions' requires 2 type argument(s).
Child InjectManifest:
     1 asset
    Entrypoint InjectManifest = sw.js
       78 modules
ℹ 「wdm」: Failed to compile.

When I set vaadin.pnpm.enable, then it seems to use pnpm instead of
npm and then I don't end up getting the compile error.

@msabramo msabramo force-pushed the vaadin.pnpm.enable=true branch from 4c981b9 to a7a38a8 Compare June 29, 2022 13:43
Without this, when I start the app, npm runs and `pnpm-lock.yaml` is
ignored and actually gets deleted and a `package-lock.json` is generated:

```
$ git status
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   .factorypath
	deleted:    pnpm-lock.yaml

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	package-lock.json
```

I think this results in getting an incorrect set of package versions,
because I get a TypeScript compile error about `IReactionOptions` in
`frontend/view.ts`:

```
ERROR in /Users/abramowi/learn/mobx/vaadin-fusion-mobx/frontend/view.ts
./view.ts
[tsl] ERROR in /Users/abramowi/learn/mobx/vaadin-fusion-mobx/frontend/view.ts(22,12)
      TS2314: Generic type 'IReactionOptions' requires 2 type argument(s).
Child InjectManifest:
     1 asset
    Entrypoint InjectManifest = sw.js
       78 modules
ℹ 「wdm」: Failed to compile.
```

When I set `vaadin.pnpm.enable`, then it seems to use pnpm instead of
npm and then I don't end up getting the compile error.
@msabramo msabramo force-pushed the vaadin.pnpm.enable=true branch from a7a38a8 to 0e8b3a6 Compare June 29, 2022 13:50
@msabramo msabramo changed the title Set vaadin.pnpm.enable = true Set vaadin.pnpm.enable = true Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant