Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code restructure and parameterize secrets #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cybermoloch
Copy link

I've changed the code around primarily to be able to pass the TenantID, ClientID, and ClientSecret as parameters. I've also made it easier to convert into a module later by making the main execution a function. (Although running it as a single script as its uses if pushing out through GPO for example.)

I would like to do some additional cleanup in regards to adding typing to more variables etc but wanted to know your interest in taking PRs.

@cybermoloch
Copy link
Author

Oh, I used VSCode's "Format Document" function which did a lot of formatting changes. Sorry if that makes it harder to review in a single commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant