Add enableSmoothing prop
#100
Open
+130
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispader
force-pushed
the
@chrispader/add-disable-smoothing-prop
branch
from
4654ae1 to
d9461e5
Compare
chrispader
force-pushed
the
@chrispader/add-disable-smoothing-prop
branch
from
7f968ba to
23e6e60
Compare
This was referenced Apr 15, 2024
added 2 commits
April 16, 2024 12:34
|
I see an issue trying to use this branch, "synchronously call non-worklet function 'linearInterpolation' " have you guys gotten similar issues? |
|
Adding 'worklet' inside linearInterpolation solves this issue |
|
Unfortunately this still doesn't solve, the multiple data points on same day and also if there is a break with the dates on data |
|
@chrispader Is there any updates on this feature? Or is there any work arounds to smoothen the graph line? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
enableSmoothingprop to<LineGraph />and adds the necessary logic to create the Skia path (createGraphPath) and calculate the Y position for the gesture (getYForX)