fix: call onPointSelected only when gesture is active #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue happening when you change
pointsafter having activated the gesture once. TheonPointSelectedcallback is executed even though there's no gesture active at the moment. You can see the problem in the video below. You'll notice that the current price changes to a "random" value that's actually what's being passed toonPointSelectedwhen thepointsprop change.ScreenRecording_09-18-2025.10-37-44.AM_1.mov
After the fix, the behavior is what I believe to be expected: the
onPointSelectedcallback is not called after changing thepoints.ScreenRecording_09-18-2025.10-45-06.AM_1.mov